Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • lava lava
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lava
  • lavalava
  • Issues
  • #564

Closed
Open
Created Sep 02, 2022 by Igor Ponomarev@igo95862Contributor

Add a throttle for "Listened connection for namespace '%s' for up to %ds" messages

Currently the connection listeners use the following code:

                       if bytes_read > 0:
                                self.logger.debug(
                                    "Listened to connection for namespace '%s' done",
                                    feedback[0],
                                )

The issue is that it might log for every byte red which spams the logs with repetitive messages.

I think it would be better to have a limit on how often this log happens. (for example, only log it if 3 second have passed since last log)

Also there is a some code repetition between

lava_dispatcher/power.py lava_dispatcher/actions/test/interactive.py lava_dispatcher/actions/test/shell.py

I think there is a place for a reusable function between those files.

Edited Sep 02, 2022 by Igor Ponomarev
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking