Skip to content

GitLab

Open
Created by eds-collabora@eds-collaboraContributor
Report abuse

Support docker login in some actions

We may sometimes want to use docker images from container registries that are behind authentication. This is not currently possible in LAVA, because there is no way to perform the necessary docker login command.

This MR adds tested docker login support to:

  • deploy:docker
  • boot:qemu
  • test:docker

And untested/experimental support to:

  • deploy:fastboot
  • boot:uuu

The rationale for the experimental support is that almost all the moving parts of the code are shared with tested cases - these are not arbitrary actions, but the ones supporting OptionalContainerMixin which allows encapsulating commands from the worker. These are much more difficult cases to test in development.

The reason not all actions are upgraded is the burden of doing so all at once, and the testing cost. This is something where we can add support to further actions incrementally.

Edited by eds-collabora