Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • lava lava
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 95
    • Issues 95
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 58
    • Merge requests 58
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lava
  • lavalava
  • Merge requests
  • !2049

Open
Created Mar 22, 2023 by Igor Ponomarev@igo95862Contributor
  • Report abuse
Report abuse

Improve logutils abstraction for internal jobs logs submission endpoint

  • Overview 2
  • Commits 1
  • Changes 3
  1. Avoid loading yaml multiple times. Instead pass the already parsed yaml to write_line method. This new method replaces write method.
  2. Fix LogsFilesystem file descriptors not being properly closed by moving all file logic inside the LogsFilesystem. That class also now handles adding new lines to the ends of the passed logged lines.
Edited Mar 22, 2023 by Igor Ponomarev
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-code-duplication-in-intelnal-jobs-logs